Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timing issue where a disconnected node is being requested & returned #362

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix timing issue where a disconnected node is being requested & returned #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87ab743
Fix timing issue where a disconnected node is being requested & returned
stevschmid Jun 21, 2023
b8ccc1e
Improve detection of disconnected nodes
stevschmid Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/ferrum/frame/runtime.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,13 @@ def handle_response(response)
# `DOM.childNodeInserted` in the future.
node_id = @page.command("DOM.requestNode", objectId: object_id)["nodeId"]
description = @page.command("DOM.describeNode", nodeId: node_id)["node"]
Node.new(self, @page.target_id, node_id, description)
node = Node.new(self, @page.target_id, node_id, description)

# Ensure node has not been disconnected between execution and
# response handling (addresses timing issues).
raise NodeNotFoundError, "Node is disconnected" unless node.evaluate('this.isConnected')

node
when "array"
reduce_props(object_id, []) do |memo, key, value|
next(memo) unless Integer(key, exception: false)
Expand Down