Add screencast functionality #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 20, 2024 13:56
|
A number of the test failures are on account of a difference between expected vs. actual screenshot height. We noticed that as of Chrome 128, the heights of our screenshot/screencast images were different from (less than) the height specified in the |
|
@bradleyscollins could you please rebase on master? after that we can merge, should be fixed in there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an API that exposes CDP's screencast capability.
See the following:
Note: At this time, the Chrome DevTools Protocol documentation still has screencast methods/types marked as "experimental."