Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rspec and initial model specs #5

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Added Rspec and initial model specs #5

wants to merge 17 commits into from

Conversation

chip
Copy link
Contributor

@chip chip commented Sep 3, 2012

This should address issue #3.

In summary, I am making the following changes with this PR:

  • Added RSpec
  • Added shoulda-matchers
  • Added initial model specs for Article, Comment, Tag and Taggings
  • Removed and ignored database, tmp and log files

@beverlynelson
Copy link
Member

@chip Yes, you're right on target with that ... also you addressed many of the things I was going to review with the group on Tuesday night at our check in. This group project [a fork of Dennis Keefe's first public Rails app] is from the exercise JSBlogger. (Good Job @denniskeefe great first step) It is definitely going to be refactored to adapt to what we need.

Several of the issues/bug_fixes and features to be added will be first attempts for the learning group which is why I left in so many files I would normally change (.gitignore etc) until we could discuss as a group and they can learn what to do/not to do.

Do you mind if I message you on FB - I'd love to add you to our group email loop so you can help mentor the new group of Rails learners starting Tuesday Sep 4th, maybe even consider a screencast explaining the changes in your PR for them?

@chip
Copy link
Contributor Author

chip commented Sep 18, 2012

@beverlynelson or @jameswritescode - I just merged in the recent master branch changes. On second thought I probably should've rebased, so I'll keep that in mind later for a cleaner history. At any rate, since this is my code, I didn't want to merge it in personally. Would one of you consider merging this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants