homework - 1 #769
Open
homework - 1 #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 20, 2018
2018/JuliaPritychenko/pascal.rb
Outdated
| end | ||
| array[0] = base_number | ||
| for j in 1..depth | ||
| (1..j).reverse_each do |i| |
There was a problem hiding this comment.
Shadowing outer local variable - i.
2018/JuliaPritychenko/pascal.rb
Outdated
| array[i] = 0 | ||
| end | ||
| array[0] = base_number | ||
| for j in 1..depth |
2018/JuliaPritychenko/pascal.rb
Outdated
| print "Enter basic number: " | ||
| base_number = gets.to_i | ||
| array = [] | ||
| for i in 1..depth |
2018/JuliaPritychenko/pascal.rb
Outdated
| @@ -0,0 +1,16 @@ | |||
| print "Enter depth: " | |||
| depth = gets.to_i | |||
| print "Enter basic number: " | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
2018/JuliaPritychenko/pascal.rb
Outdated
| @@ -0,0 +1,16 @@ | |||
| print "Enter depth: " | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
houndci-bot
reviewed
Feb 20, 2018
| array[i] = array[i - 1] + array[i] | ||
| end | ||
| puts | ||
| end |
houndci-bot
reviewed
Feb 20, 2018
2018/JuliaPritychenko/pascal.rb
Outdated
| end | ||
| puts | ||
| end | ||
|
|
Xanderwot
suggested changes
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Фамилия Имя
Притыченко Юлия
Email
[email protected]
Номер домашнего задания
1
Ссылка на видео с демо работы
https://www.youtube.com/watch?v=CroOC2aGbVg&feature=youtu.be
Комментарии
Хотел сделать красоту, но не знаю как.