Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional oauth support #5247

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: optional oauth support #5247

wants to merge 5 commits into from

Conversation

sanpj2292
Copy link
Contributor

Description

Currently we would be attach OAuth framework specific things when we identify(auth.type) from the destination definition config to be OAuth, which would mean user would be restricted to go ahead with only OAuth not anything else.

In the past there have been use-cases where a destination would need to support multiple authentication mechanisms. We would need to provide multiple authentication mechanisms in the UI
In order to fulfil this, we have added auth.type as optionalAuth in the destination definition config. We are using this to identify if a destination optionally selected OAuth & also confirm if account id information is available in destination.config for attaching OAuth framework specific things

Linear Ticket

Resolves INT-2832

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@sanpj2292 sanpj2292 self-assigned this Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.25%. Comparing base (6abcedd) to head (5079632).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5247      +/-   ##
==========================================
- Coverage   73.27%   73.25%   -0.03%     
==========================================
  Files         424      424              
  Lines       59960    59980      +20     
==========================================
+ Hits        43936    43938       +2     
- Misses      13559    13585      +26     
+ Partials     2465     2457       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant