-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: identify and track for loops #3976
base: develop
Are you sure you want to change the base?
Conversation
Thank you @danrowden for contributing this PR. |
Co-authored-by: Yashasvi Bajpai <[email protected]>
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
|
||
- name: validateIdentifyEmail | ||
condition: $.outputs.messageType === {{$.EventType.IDENTIFY}} | ||
template: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const email = .message.({{{{$.getGenericPaths("emailOnly")}}}});
payload.userId = .message.userId; | ||
payload.eventName = .message.event; | ||
payload.eventProperties = .message.properties; | ||
$.context.payload = payload; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow this . Final Response step is missing here.
destinationId: 'destId', | ||
workspaceId: 'wspId', | ||
}, | ||
output: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the above doc to get the output in required format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example for your ref
What are the changes introduced in this PR?
Added Identify and Track events for new Loops destination.
Current status: This is a first go at implementing a new destination, so it's considered WIP until checked by someone more familiar with Rudderstack.
What is the related Linear task?
None
Please explain the objectives of your changes below
New destination for Loops that lets users sync contacts into Loops and sent events to Loops (to trigger email sending).
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.