Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify types and generalise existing types #4039

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

vinayteki95
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (a59fab2) to head (4c452ae).
Report is 3 commits behind head on feat.customerio_segmen.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat.customerio_segmen    #4039      +/-   ##
==========================================================
- Coverage                   90.86%   90.85%   -0.01%     
==========================================================
  Files                         630      630              
  Lines                       32813    32788      -25     
  Branches                     7786     7777       -9     
==========================================================
- Hits                        29814    29790      -24     
+ Misses                       2744     2743       -1     
  Partials                      255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/types/index.ts Outdated Show resolved Hide resolved
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

sonarqubecloud bot commented Feb 3, 2025

@koladilip koladilip marked this pull request as ready for review February 3, 2025 04:30
@koladilip koladilip requested review from a team and sivashanmukh as code owners February 3, 2025 04:30
@koladilip koladilip requested review from koladilip and chandumlg and removed request for a team February 3, 2025 04:30
@koladilip koladilip merged commit ab88c7b into feat.customerio_segmen Feb 3, 2025
24 checks passed
@koladilip koladilip deleted the chore.customerio-enhancements branch February 3, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants