ci: Run Rust tests on Ubuntu 24.04 #16352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good so far... 🥳 🤞 |
torokati44
force-pushed
the
ci-ubuntu-24.04
branch
from
34892da to
4d879cb
Compare
torokati44
force-pushed
the
ci-ubuntu-24.04
branch
from
4d879cb to
f0590e4
Compare
torokati44
force-pushed
the
ci-ubuntu-24.04
branch
2 times, most recently
from
338dd87 to
59c24cc
Compare
torokati44
force-pushed
the
ci-ubuntu-24.04
branch
from
59c24cc to
f8b4f64
Compare
torokati44
force-pushed
the
ci-ubuntu-24.04
branch
2 times, most recently
from
b609382 to
1a48cc1
Compare
13 tasks
|
Posted actions/runner-images#10374 due to the Firefox WebDriver failures. |
|
While the Edge people figure their shoot out, we could switch to 24.04 only for the Rust tests...? |
torokati44
force-pushed
the
ci-ubuntu-24.04
branch
from
1a48cc1 to
8dfc80c
Compare
torokati44
changed the title
Removed the web test workflow updates from this PR, will submit those separately. |
torokati44
force-pushed
the
ci-ubuntu-24.04
branch
from
8dfc80c to
e044881
Compare
Dinnerbone
force-pushed
the
ci-ubuntu-24.04
branch
from
e044881 to
884fe8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently available as beta on GHA: https://github.blog/changelog/2024-05-14-github-hosted-runners-public-beta-of-ubuntu-24-04-is-now-available/
Just want to see whether anything will break once we switch, plus whether we can clean up the tricks we did to get Lavapipe, and to tolerate SIGABRT.
A minor added benefit is that we won't lose CI if/when Launchpad is down (as has happened a couple times recently), and that nextest will alert us of genuinely flaky tests with higher probability (the retries hack won't hide them). Also, the Ubuntu jobs will be a bit faster.
Note that after merging this, the set of required checks will have to be updated by a repo admin to match.