[AVM1 debug ui] Make some object properties editable #17279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crumblingstatue
force-pushed
the
avm1-debug-object-edit
branch
from
187ed85 to
107ae4c
Compare
crumblingstatue
changed the title
crumblingstatue
force-pushed
the
avm1-debug-object-edit
branch
2 times, most recently
from
63790e4 to
66fd10f
Compare
crumblingstatue
changed the title
crumblingstatue
commented
Aug 2, 2024
| mutation: &Mutation<'gc>, | ||
| ) -> Option<Value<'gc>> { | ||
| let mut new = None; | ||
| egui::ComboBox::new(egui::Id::new("value_combo").with(key), "Type") |
There was a problem hiding this comment.
Perhaps the "Type" label is a bit redundant, and the dropdown menu is obvious enough without the label.
Dinnerbone
force-pushed
the
avm1-debug-object-edit
branch
2 times, most recently
from
6b3a55c to
a0c758d
Compare
Dinnerbone
force-pushed
the
avm1-debug-object-edit
branch
from
a0c758d to
79817ee
Compare
This removes a lot of extra arguments, and avoids triggering `clippy::too_many_arguments` lint.
In order to avoid having too many arguments
Dinnerbone
force-pushed
the
avm1-debug-object-edit
branch
from
79817ee to
3762523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing object properties can be useful for helping debugging games, or just cheating/general messing around.
Also adds a filter to quickly find fields of interest.
Todo
Attempt to add AVM2 supportAVM2 debug ui code would require significant changes to add editing support, and I want to keep this pull request fairly simple. Perhaps a followup/intermediate step would be some refactoring and unification work on the AVM1 and AVM2 debug UI code.
WStringas key instead ofStringScreenshot of what it looks like:
