Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: Fix a bunch of API mismatches (versions/base class/accessors) #17291

Merged
merged 19 commits into from
Jul 29, 2024

Conversation

Dinnerbone
Copy link
Contributor

It's not everything, we have some issues remaining, but it's a pretty good chunk


Remaining issues if anyone else wants to tackle those:

String static has extra method "fromCharCode"

This is technically correct, the worst kind of correct. Flash doesn't define it on the class, somehow. I didn't care enough to figure out why.


flash.accessibility.AccessibilityImplementation has extra method "get_selectionActiveIndex"
flash.accessibility.AccessibilityImplementation has extra method "get_selectionAnchorIndex"

Should be gated behind API 736 which ruffle doesn't support


flash.display3D.Context3D variable "maxBackBufferWidth"'s access should be "readwrite", actually "readonly"
flash.display3D.Context3D variable "maxBackBufferHeight"'s access should be "readwrite", actually "readonly"

Didn't really feel like touching context3d stuff :D


flash.events.GestureEvent has extra variable "controlKey"
 
flash.events.KeyboardEvent has extra variable "controlKey"
flash.events.KeyboardEvent has extra variable "commandKey"
 
flash.events.PressAndTapGestureEvent has extra variable "controlKey"
 
flash.events.TransformGestureEvent has extra variable "controlKey"

I couldn't find a consistent answer on what these should be gated behind, the docs and playerglobals seem inconsistent.


flash.net.SharedObject variable "data"'s access should be "readonly", actually "readwrite"
flash.net.SharedObject has extra variable "_ruffleName" (uri "__ruffle__")

Looked too scary


flash.net.URLLoader variable "bytesTotal"'s access should be "readwrite", actually "readonly"
flash.net.URLLoader variable "bytesLoaded"'s access should be "readwrite", actually "readonly"

Also scary


flash.system.IME has extra variable "isSupported"

Docs were inconsistent with playerglobals

@Dinnerbone Dinnerbone merged commit 3de0279 into ruffle-rs:master Jul 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants