-
-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avm2: Fix a bunch of API mismatches (versions/base class/accessors) #17291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly wrapper around allowCodeImport
Dinnerbone
force-pushed
the
avm2_type_fixups
branch
from
July 28, 2024 21:43
30bf191
to
1ba5945
Compare
adrian17
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not everything, we have some issues remaining, but it's a pretty good chunk
Remaining issues if anyone else wants to tackle those:
This is technically correct, the worst kind of correct. Flash doesn't define it on the class, somehow. I didn't care enough to figure out why.
Should be gated behind API 736 which ruffle doesn't support
Didn't really feel like touching context3d stuff :D
I couldn't find a consistent answer on what these should be gated behind, the docs and playerglobals seem inconsistent.
Looked too scary
Also scary
Docs were inconsistent with playerglobals