avm2: Remove PrimitiveObject #18995
Merged
avm2: Remove PrimitiveObject #18995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
added
A-avm2
Lord-McSweeney
force-pushed
the
avm2-primobj-4
branch
2 times, most recently
from
c66ee38 to
cb921ef
Compare
Lord-McSweeney
added
the
waiting-on-review
Lord-McSweeney
force-pushed
the
avm2-primobj-4
branch
3 times, most recently
from
27133cb to
f4a3a61
Compare
Lord-McSweeney
force-pushed
the
avm2-primobj-4
branch
from
f4a3a61 to
4cdf0ea
Compare
torokati44
force-pushed
the
avm2-primobj-4
branch
from
4cdf0ea to
e21aaad
Compare
adrian17
reviewed
Jan 11, 2025
| @@ -1 +1 @@ | |||
| ReferenceError: Error #1069: Property field not found on int and there is no default value. | |||
| ReferenceError: Error #1069: Property field not found on Number and there is no default value. | |||
| /// structured objects. | ||
| #[allow(unused_mut)] //Not unused. | ||
| #[no_dynamic] | ||
| fn get_property( |
There was a problem hiding this comment.
why not keep these, if only as
fn get_property(...) {
Value::from(self).get_property(...)
}
?
This would prevent several dozen Value::from(self).get_property(...) changes in other places, and feels like a nice QoL wrapper to have in general.
Lord-McSweeney
force-pushed
the
avm2-primobj-4
branch
from
e21aaad to
0d42d3f
Compare
adrian17
approved these changes
Jan 13, 2025
Lord-McSweeney
force-pushed
the
avm2-primobj-4
branch
from
0d42d3f to
fa9f700
Compare
Lord-McSweeney
force-pushed
the
avm2-primobj-4
branch
from
fa9f700 to
95f8b2c
Compare
Lord-McSweeney
removed
the
waiting-on-review
added 11 commits
January 14, 2025 16:46
…ssociated functions to construct events in more places
torokati44
force-pushed
the
avm2-primobj-4
branch
from
95f8b2c to
691a35f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #13152.
Testing on #15485 shows no significant change in its startup time.
Closes #15517.
This also refactors event dispatch code to accept an EventObject instead of a Value or Object