Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Use std::call_once to arrange timer record stop #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmantipov
Copy link
Contributor

Prefer std::once_flag and std::call_once() over plain
C-style flag to arrange (the body of) TimerRecord::stop()
to execute just once, adjust related code.

Signed-off-by: Dmitry Antipov [email protected]

Prefer 'std::once_flag' and 'std::call_once' over plain
C-style flag to arrange (the body of) 'TimerRecord::stop()'
to execute just once, adjust related code.

Signed-off-by: Dmitry Antipov <[email protected]>
@rui314
Copy link
Owner

rui314 commented Feb 14, 2022

std::call_once is used to make the thing that is protected by call_once thread-safe. In this case, stop is called by a single thread, so we don't need to use call_once.

@rui314 rui314 force-pushed the main branch 4 times, most recently from 2d15d52 to e47c677 Compare February 22, 2022 02:50
@rui314 rui314 force-pushed the main branch 2 times, most recently from f797b76 to a44de89 Compare February 24, 2022 02:32
@rui314 rui314 force-pushed the main branch 13 times, most recently from 4652763 to 230976a Compare May 1, 2022 08:04
@rui314 rui314 force-pushed the main branch 2 times, most recently from 192efa1 to a1711b9 Compare May 21, 2022 12:31
@rui314 rui314 force-pushed the main branch 3 times, most recently from ccf2cda to 7d91674 Compare August 3, 2022 03:29
@rui314 rui314 force-pushed the main branch 2 times, most recently from bf2c440 to df9e997 Compare December 31, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants