chore: Add Close Calls to BoltDB Tests to fix Windows Test Errors #5289
+80
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: X-Guardian <[email protected]>
Signed-off-by: X-Guardian <[email protected]>
X-Guardian
requested review from
chenrui333,
lukemassa and
nitrocode
and removed request for
a team
lukemassa
reviewed
Feb 1, 2025
| @@ -0,0 +1,197 @@ | |||
| package events | |||
There was a problem hiding this comment.
This and other .copy files, are they intentionally added?
There was a problem hiding this comment.
My bad. Accidentally committed some of my test files. Removed now.
server/metrics/debug.go
Outdated
| @@ -38,18 +38,18 @@ func (r *debugReporter) Flush() { | |||
| } | |||
|
|
|||
| func (r *debugReporter) ReportCounter(name string, tags map[string]string, value int64) { | |||
There was a problem hiding this comment.
Any reason to comment these log lines out?
Signed-off-by: X-Guardian <[email protected]>
X-Guardian
force-pushed
the
boltdb-test-close-fix
branch
from
c2fa89f to
82607eb
Compare
lukemassa
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add
closecalls to all the BoltDB instances that are created in the unit tests.why
On Windows, running any of the unit test that use test BoltDB instances results with failures on test clean-up of:
Adding the correct clean-up of these databases resolves this issue.
tests
Tested locally