Create a public function for source formatting #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't have to use anyhow to hide the error enum. A public struct with a private field implementing std::error::Error would achieve the same result without the feature test. |
|
Woops, the auto merged triggered prior to building 🤔. No big deal, I'll fix it when I get around to it. Thanks! |
|
Ooop, it seems my commit makes build failure. Let me create PR for the fix. |
cocuh
added a commit
to cocuh/lang-rune
that referenced
this pull request
Feb 22, 2024
udoprog
pushed a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution for #652.
In most cases, users don't need FormattingError enum itself, and just serializing the error message makes things easier in later code chagnes I believe.