Add Value::borrow_any_{ref,mut} to get a typed reference without ownership #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udoprog
reviewed
Mar 1, 2024
crates/rune/src/runtime/value.rs
Outdated
| @@ -1335,6 +1335,23 @@ impl Value { | |||
| VmResult::Ok(vm_try!(Future::from_value(value))) | |||
| } | |||
|
|
|||
| /// Get the value as a typed value. | |||
| #[inline] | |||
| pub fn as_any<T>(&self) -> Result<BorrowRef<'_, T>, RuntimeError> | |||
There was a problem hiding this comment.
Naming when there's this many methods is tricky, and something I'll definitely want to go over before the next release. The pattern with the macros currently is:
borrow_<type>_refborrow_<type>_mutinto_<type>_refinto_<type>_mut
But this doesn't mesh well with any. But maybe this as a result should be borrow_any_ref?
dstoza
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.