Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RuneLingual #7141

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Create RuneLingual #7141

wants to merge 14 commits into from

Conversation

YS-jack
Copy link

@YS-jack YS-jack commented Dec 11, 2024

Translation Plugin: RuneLingual

This is a translation plugin, which hopefully puts an end to the ever-increasing number of translation plugins.
It translates everything, which surprisingly no other plugins have managed to do.

  • Universal Translation: Other translation plugins only translate one or a few elements, such as dialogues, chats, or menu entries, and most of them only support one or two languages. RuneLingual translates everything, and can easily expand supported language via DeepL.
  • Non-Latin Characters: Can type and chat in non-Latin characters, which has never been done before.
  • Multiple Translation Methods: Translates via manual transcripts or DeepL.

Currently, RuneLingual only supports Japanese, but it should be easy to implement other languages, especially those using Latin characters.

For more detailed information, please refer to the README and the README for developers.

There are some improvements (like adding other languages) that could be done, but the code is large enough already, I thought I should do it after initial launch.

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 11, 2024

@YvesW
Copy link
Member

YvesW commented Dec 22, 2024

Do we really need a 6th translation plugin?

It translates everything

Currently, RuneLingual only supports Japanese

Right now this just looks like https://xkcd.com/927/

@YS-jack
Copy link
Author

YS-jack commented Dec 23, 2024

What if I came back with this plugin translating more languages? Adding languages which are supported by deepl and use latin characters would be simple to add. Languages using non latin characters will take more time but is doable. I just wanted the review to be easier and hopefully not take as long

Adding this plugin's functionality to existing one could be complicated for the existing users, but i could try if thats what you are requesting

I'm also hesitant after seeing this
#6125 (comment)

My plugin is also not small

@raiyni
Copy link
Member

raiyni commented Dec 23, 2024

polywoof already supports deepl integration

@YS-jack
Copy link
Author

YS-jack commented Dec 23, 2024

Polywoof only translates dialogues, mine can translate other elements too

@YS-jack
Copy link
Author

YS-jack commented Dec 23, 2024

I could ask if polywoof's developer if he's interested in upgrading his plugin, but ive talked to him before and he didnt seem too interested
edit: I asked and basically he said no

@LlemonDuck
Copy link
Contributor

Ok, that's fine. Thanks for checking though! I'll review this one when I get a chance.

@Felanbird
Copy link
Contributor

As this is a fork, issues are not enabled by default, so users will currently be unable to open issue reports
380997175-658b6239-0107-425c-8ff2-44bec8c19e77

@YS-jack
Copy link
Author

YS-jack commented Dec 24, 2024

Ok, that's fine. Thanks for checking though! I'll review this one when I get a chance.

Thanks to all RuneLite developers for their time!

As this is a fork, issues are not enabled by default, so users will currently be unable to open issue reports

OK I think I enabled it just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants