Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rogue-husher #7142

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Create rogue-husher #7142

wants to merge 8 commits into from

Conversation

LeeT96
Copy link

@LeeT96 LeeT96 commented Dec 11, 2024

Simple plugin that removes "Someone's stealing from us, get them!" when stealing from the chest at the Rogue's castle.

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 11, 2024

@raiyni
Copy link
Member

raiyni commented Dec 11, 2024

Can this be accomplished with chat filter

@LeeT96
Copy link
Author

LeeT96 commented Dec 11, 2024

Can this be accomplished with chat filter

It didn't work for me when I was testing.

@LlemonDuck
Copy link
Contributor

You should remove your config class (and the one in test source) altogether

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 19, 2024
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 19, 2024
@LeeT96
Copy link
Author

LeeT96 commented Dec 19, 2024

You should remove your config class (and the one in test source) altogether

Done

@YvesW
Copy link
Member

YvesW commented Dec 22, 2024

You are adding 2 plugins here. Please rebase and only add 1.

Also, just make this 1 plugin instead of 2, and like I suggested before: wouldn't it be nice to e.g. PR this to other plugins like chop chop stop?

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants