Add RuneShare plugin

[kcdragon]

RuneShare is a web app and plugin I'm developing to share and discover bank tabs. This plugin sends bank tag tab data (from the Bank Tabs plugin) to https://osrs.runeshare.app/. Each player has their own account on RuneShare and they use an API token to configure the plugin. It's currently a one way sync. Changes are sent to the web app but not from the web app to the plugin.

There are two sync modes: auto sync and manual sync. By default, manual sync is enabled and the player chooses which bank tag tabs to sync. If auto sync is enabled, the active bank tag tab will be synced.

The README describes the setup instructions for the plugin.

Let me know if I can add any more details to help the review process. I appreciate you reviewing. Thanks!

[runelite-github-app]

New plugin runeshare: https://github.com/kcdragon/runeshare-plugin/tree/94bc765e077b786f18730624727908819258f39e

[LlemonDuck]

• You should add default values here https://github.com/kcdragon/runeshare-plugin/blob/00fa4ac1ba9bfc7f2bb9c87f420aa47a71cdddad/src/main/java/app/runeshare/RuneShareConfig.java

@ConfigItem(...)
default String apiToken() { return null; }

@ConfigItem(...)
default boolean autoSave() { return true; } // or false?

[raiyni]

This looks like it will also block the client thread and swing thread. Please inject our okhttp client and use enqueue.

[kcdragon]

Thanks for taking a look! I'll implement the changes.

[kcdragon]

@LlemonDuck @raiyni Thanks for the feedback. I think I fixed those issues correctly but let me know if I didn't and need to make a change. Thanks!

[LlemonDuck]

The client thread and the Swing thread are different things, don't use Client#invokeLater to perform Swing operations: https://github.com/kcdragon/runeshare-plugin/blob/f84a42f818694a38252035f5b1b81f0d0cf9639a/src/main/java/app/runeshare/RuneSharePlugin.java#L102-L104

[kcdragon]

@LlemonDuck Ah I think I see what you mean now. I changed the clientThread.invokeLater calls to SwingUtilities.invokeLater. Is that what you were looking for? Thanks!