Update tasks-tracker

[JamesShelton140]

Replaced the last instance of clientThread::invokeLater called during plugin startup with clientThread::invoke to prevent a hang on auto profile switch as indicated by runelite/runelite#18618 (comment)

We were not able to recreate the freeze/hang to confirm this fix but a similar change in the previous commit (osrs-reldo/tasks-tracker-plugin@b57d548) fixed an instance of the hang we were able to replicate.

[runelite-github-app]

Includes changes by non-author

tasks-tracker: b57d548986e211fdd1b77d7af6826cda7ffef3dc...1f8d2b36e44ef80b88345a3b38117424a8983324

[iProdigy]

Could yall refactor away the blocking usage of CompletableFuture? (keep it async as intended)

[JamesShelton140]

Blocking usage of CompletableFuture refactored out as requested:

osrs-reldo/tasks-tracker-plugin@f797743

[iProdigy]

Should this be wrapped in a SwingUtilities.invokeLater: https://github.com/osrs-reldo/tasks-tracker-plugin/blob/f7977432f12a02c1ad76e7f82a1f6db55978a25f/src/main/java/net/reldo/taskstracker/panel/LoggedInPanel.java#L339-L340

Perhaps also @ https://github.com/osrs-reldo/tasks-tracker-plugin/blob/f7977432f12a02c1ad76e7f82a1f6db55978a25f/src/main/java/net/reldo/taskstracker/TasksTrackerPlugin.java#L219 & https://github.com/osrs-reldo/tasks-tracker-plugin/blob/f7977432f12a02c1ad76e7f82a1f6db55978a25f/src/main/java/net/reldo/taskstracker/TasksTrackerPlugin.java#L307 to be safe

[JamesShelton140]

It's not necessary to prevent hangs/exceptions since the thread is checked before swing components are modified but I have wrapped the calls as suggested anyway since they were sometimes being rejected for being on the wrong thread.

osrs-reldo/tasks-tracker-plugin@1f8d2b3

[CC007]

Any idea when this could get merged? Preferably before Leagues is over. Otherwise it kind of defeats the purpose.

[raiyni]

We were not able to recreate the freeze/hang to confirm this fix

Doesn't inspire confidence if this fixes the freeze or not

[Ryanleonard9]

@JamesShelton140 @raiyni as a neutral third party who has been anxiously awaiting this plugin to come back online, I recently downloaded runelite locally as well as the plugin, and I've been swapping between main game and leagues quite a bit the last few days and have yet to experience any slowness, crashing or anything out of the ordinary. If you'd like to message me for an sort of validation, let me know and im happy to provide whatever may be needed.

[SeaifanAladdin]

We were not able to recreate the freeze/hang to confirm this fix

Doesn't inspire confidence if this fixes the freeze or not

I have just spent some time trying to test this change by attempting to reproduce the freeze/hang using the steps outlined runelite/runelite#18618 (comment)

What I did is I compiled 2 different versions of the plugin, and had RuneLite load them as if they were fetched from the Plugin Hub directly.

1. Old version with the commit osrs-reldo/tasks-tracker-plugin@b57d548
2. The new version with the commit osrs-reldo/tasks-tracker-plugin@1f8d2b3

As expected, the old version of the plugin does freeze and hang when switching between profiles.
I performed the same tests with the new version and I no longer see any freezes or hangs

[tylerthardy]

Anything we can do to help with this PR?