Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create music-track-display #7182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Tommynaut
Copy link

A simple plugin that displays the current music track as a game message in the console.
Fair warning that this was created by someone relatively novice.

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 27, 2024

Fixed an issue with the plugin field for the runelite-plugin.properties file.
@Tommynaut
Copy link
Author

Tommynaut commented Dec 27, 2024 via email

@raiyni
Copy link
Member

raiyni commented Dec 27, 2024

I would assume there is a varbit changed or client script that's called.

@LlemonDuck
Copy link
Contributor

The checks you're performing are simple enough and I wouldn't worry about trying to optimize it prematurely. But you should remove your config since it is unused.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 28, 2024
@Tommynaut
Copy link
Author

The checks you're performing are simple enough and I wouldn't worry about trying to optimize it prematurely. But you should remove your config since it is unused.

Thank you for your suggestion.
Is it okay if I leave the config file in there and comment out everything related to it, including its contents? I was thinking of using the config later when I have more time to add some other features and my intention was to keep it as a template for when I do make changes.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 28, 2024
@LlemonDuck
Copy link
Contributor

Sure, but in that case you should also comment out its @Provides block in the plugin class.

I say this only because having it present means there will be a config gear icon beside the plugin name, which can be confusing for users if it opens to a blank page. If you want to add the config later it won't cause any issues to re-add the provider.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 28, 2024
Updated files to disable the currently-unused config
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 29, 2024
@Tommynaut
Copy link
Author

Sure, but in that case you should also comment out its @Provides block in the plugin class.

I say this only because having it present means there will be a config gear icon beside the plugin name, which can be confusing for users if it opens to a blank page. If you want to add the config later it won't cause any issues to re-add the provider.

Thank you LlemonDuck, that makes sense. I have updated the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants