-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create music-track-display #7182
base: master
Are you sure you want to change the base?
Conversation
New plugin |
Fixed an issue with the plugin field for the runelite-plugin.properties file.
Hi Chris,
Thanks for your message.
Apologies if I'm replying the wrong way, I couldn't see your message on
GitHub and can only see it in my emails. It's probably obvious that I'm new
to this.
With regard to what you said, I have tested this and it doesn't seem to
spam the chatbox - it only sends the message when the music track changes.
I have it running every tick because there didn't seem to be a better way
to check for the track change as an event (there's no associated variable
client-side).
Did you test it and see it spam the chatbox?
Kind regards,
Thomas
…On Fri, Dec 27, 2024 at 9:31 PM Chris ***@***.***> wrote:
This isn't at all a full review but doing this every game tick is VERY
quickly going to spam the user's chatbox with nothing but this message
—
Reply to this email directly, view it on GitHub
<#7182 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUA6RALMIP4AIL4X7XNOGT2HUUAVAVCNFSM6AAAAABUIMUFHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRTGU3DAMBZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I would assume there is a varbit changed or client script that's called. |
The checks you're performing are simple enough and I wouldn't worry about trying to optimize it prematurely. But you should remove your config since it is unused. |
Thank you for your suggestion. |
Sure, but in that case you should also comment out its I say this only because having it present means there will be a config gear icon beside the plugin name, which can be confusing for users if it opens to a blank page. If you want to add the config later it won't cause any issues to re-add the provider. |
Updated files to disable the currently-unused config
Thank you LlemonDuck, that makes sense. I have updated the file. |
A simple plugin that displays the current music track as a game message in the console.
Fair warning that this was created by someone relatively novice.