Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flipping-copilot to v1.6.0 #7184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cbrewitt
Copy link
Contributor

Major refactor and improve transaction inference

  • Refactor all depedencies to use constructor based injection where possible
  • Restructure code to more cleanly follow MVC pattern:
    • Controller/Handler classes should have minimal state
    • State should be stored and managed in 'Manager' classes
    • Manager classes should not reference Controllers or Views (JPanels)
    • Controllers and Views (JPanels) may reference each other
  • Disentangle state from Controller/View classes
  • Update the handling of offer events for inferring transactions based on GrandExchangePlugin code
  • Construct the AccountStatus on the fly directly from client.getGrandExchangeOffers() to avoid sync issues
  • Track the uncollected quantities explciitly in an independent Manager
  • Use accountHash instead of displayName where possible
  • Include a machine ID + additional flags on transactions to help track/clean up bad transactions
  • Simplify the osrs login management
  • Add suggestion settings tab in suggestions panel
  • Move sell only toggle to suggestion settings
  • Add blacklist UI feature

@runelite-github-app
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant