Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wilderness-player-alarm #7185

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Update wilderness-player-alarm #7185

merged 2 commits into from
Dec 30, 2024

Conversation

adhansen
Copy link
Contributor

Summary

New version of the Wilderness Player Alarm with improvements for plugin inter-operability

Detail

There are two main issues with the plugin that I'm trying to fix here:

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 29, 2024

@iProdigy
Copy link
Member

Are you intentionally resetting flashControl to NORMAL for plugin users who previously configured this value to something else? if not, you can revert the flashSpeed config key name to flashControl

@adhansen
Copy link
Contributor Author

Are you intentionally resetting flashControl to NORMAL for plugin users who previously configured this value to something else? if not, you can revert the flashSpeed config key name to flashControl

I'm aware that it will reset this config item. I guess I could revert the keyName, but I definitely would like to change the name as it appears in the user-facing settings. Alright hold off on merge I'll change that back...

@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 29, 2024
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 29, 2024
@tylerwgrass tylerwgrass merged commit 086131c into runelite:master Dec 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants