Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dialog-font-changer plugin #7189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andrewmenich
Copy link

This plugin replaces the standard dialog box quill font with a list of other font options. The goal of this plugin is to make the dialog box more legible and customizable, particularly for those with vision impairments. It works by hiding the original widget and creates a new overlay in its place. It currently only handles NPC and optionally Player dialog.

@runelite-github-app
Copy link

@raiyni
Copy link
Member

raiyni commented Dec 30, 2024

Please don't open new prs. You can push changes to your current branch and update the commit hash here.

@andrewmenich
Copy link
Author

Please don't open new prs. You can push changes to your current branch and update the commit hash here.

Sorry about that! Was just rereading the contribution docs and realized my mistake.

@raiyni
Copy link
Member

raiyni commented Dec 30, 2024

Is there a reason you didn't just change the FontID? https://static.runelite.net/api/runelite-api/net/runelite/api/FontID.html

@andrewmenich
Copy link
Author

I explored that initially and it's definitely the path of least resistance. PLAIN_12, VERDANA_13, and their bold counterparts work well, I just didn't find them to be as legible as I was hoping for (namely for quest dialog where there is lots of reading). I started playing around with rendering my own overlay and found that using more common fonts like Roboto/Lato were exactly what I was looking for. If this approach is a blocker I'd definitely settle for the former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants