-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSRS-Splits-TheKodai #7207
OSRS-Splits-TheKodai #7207
Conversation
Includes non-plugin changes New plugin |
dependencies needed for osrs-splits-the-kodai
Is there a reason you cannot use already included versions of the dependencies you have changed, and how is this different from your already existing Nex Split Tracker plugin? |
This should be added to the nex plugin you already have |
The original Nex Split Tracker is used as a in client spread sheet to track drops from random teams and display profit from splits. Much like the Raids Tracker. The proposed plugin unites the community of OSRS Splits The Kodai and RuneWatch to help prevent scams and instill trust in the community members. Community members voluntarily sign up through discord so their accounts may be tracked, these accounts are tracked regardless of x name changes so scamming is highly discouraged as members who do not split valuable drops with their party members will be tracked via RuneWatch. This plugin does not track the splits in a spreadsheet format, rather posts the confirmations of party members agreeing to the TOS of the community of RuneWatch and OSRS Splits, and any and all unique drops from the Nex encounter itself. All parties have clear and automated evidence to help maintain transparency when playing with strangers and help with any dispute among RuneWatch cases. This plugin aims to help the community while discouraging scamming by unavoidable long term consequences via RuneWatch. EDIT: I changed the dependencies to versions that are already on the list, sorry I'm smooth brain. |
I still don't see a reason this can't be added to the nex split plugin that you already own with the same name. Just add a config section for it and it works. Also, inject our okhttp and use that instead of what you are doing now for http calls. Still got the dependency changes label because you are changing stuff. I've not looked if what you are doing is ok or just weird. Usually proper authentication of an osrs account doesn't really work unless you do a skilling challenge with hiscore checks or something like that. |
Merge with existing Nex Split Plugin: Dependency: Account authentication: |
Please stop using an LLM to write your messages if you are. Keep it clear and concise. Currently multiple reviewers think it's best to integrate the plugins, so I strongly recommend just doing that. You don't have to make arbitrary differences between them. For example the ToA plugin by Llemon also does it all in 1 plugin. No reason to split it out in 20 plugins. There's still a dependency changes tag on this PR. I think the bot will remove it when there are actual no dependency changes (e.g. the exclude you added). |
As mentioned before I did not have any LLMs write the response. I was under the impression since there was a discrepancy, more information regarding the matter would be useful to identify key differences between the two plugins. It is mere coincidence that the community OSRS Splits and Nex Split Tracker have similar names, and boss Nex. I am currently updating the code for okHttp. |
This can be added to the existing plugin as a config option, which would make it not required for every user of the plugin. |
Alright, if that is what you want I will add them together. A new PR will be generated with the reflected incoming changes. |
|
OSRS Splits – The Kodai
A custom RuneLite plugin for managing parties, verifying members, and automatically capturing Nex loot screenshots—improving safety and trust in OSRS Splits and RuneWatch communities. Includes straightforward creation/joining of parties, split confirmations, and quick screenshot uploads to Discord. Name changes won’t hide a bad actor—verified members are tracked permanently. Enjoy Nex with peace of mind!