Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve responsiveness in grid #2602

Merged

Conversation

tonkec
Copy link
Contributor

@tonkec tonkec commented Dec 18, 2024

Fixes issue

Closes #2609

Changes proposed

  • fixing paddings and margins in contributor grid item

Screenshots

BEFORE

  • icons are falling out of the box
    Screenshot 2024-12-18 at 08 16 05

AFTER

Screenshot 2024-12-18 at 08 18 55

Note to reviewers

  • this is my first PR to this beautiful repo
  • I hope to contribute more and learn from the best <3

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 7:42am

@github-actions github-actions bot added bug Something isn't working priority: medium Modifying an existing feature labels Dec 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, tonkec, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@rupali-codes
Copy link
Owner

Hi @tonkec do we have a closing issue for it?

@github-actions github-actions bot mentioned this pull request Dec 22, 2024
3 tasks
@tonkec
Copy link
Contributor Author

tonkec commented Dec 22, 2024

@rupali-codes I just created an issue and referenced it in this MR. Is that ok?

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tonkec, lgtm.

@rupali-codes rupali-codes merged commit 7d43caf into rupali-codes:main Dec 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Icons falling out of the box
2 participants