Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove to_string methods implemented manually #50

Closed
wants to merge 1 commit into from
Closed

fix: remove to_string methods implemented manually #50

wants to merge 1 commit into from

Conversation

hnlcf
Copy link

@hnlcf hnlcf commented Oct 19, 2022

SmolStr already implements the Display trait, and the ToString trait will be implemented automatically.

@hnlcf
fix: remove to_string methods implemented manually
72cd405 
SmolStr already implements the `Display` trait, and the `ToString` trait will be implemented automatically.
msdrigg
msdrigg approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@msdrigg msdrigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

I was worried this messing up the MSRV, but I just checked and there is no MSRV policy.

@Veykril
Copy link
Member

Veykril commented Sep 3, 2024

Will be done by #82

@Veykril Veykril closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msdrigg msdrigg msdrigg approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hnlcf @Veykril @msdrigg