Add StrExt::replace_smolstr, replacen_smolstr #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
StrExt::replace_smolstr
,StrExt::replacen_smolstr
.This is useful to avoid allocation on small strings, e.g:
Impl adapted from std
str::replacen
.One undesirable difference from std is
from
usesPattern
instr::replace
but this is not stable and can't be used here. However, I still think this version withfrom: &str
is quite useful & worth having. Also if/whenPattern
stabilizes we can start using it as a non-breaking change, since&str
will implement it.Note: While not needed for this PR this kind of usage is an example of why #70 would be useful for external use.