Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -j1 to docs build invocation #18

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

tcharding
Copy link
Member

After upgrade of hashes but before we upgrade it in secp we get multiple versions in the dep tree. This makes the docs build choke because output directory uses the name of the crate (without the version) which then conflicts and causes the build to fail.

Adding -j1 so that only a single job is run when building the docs resolves the issue.

After upgrade of `hashes` but before we upgrade it in `secp` we get
multiple versions in the dep tree. This makes the docs build choke
because output directory uses the name of the crate (without the
version) which then conflicts and causes the build to fail.

Adding `-j1` so that only a single job is run when building the docs
resolves the issue.
@tcharding tcharding changed the title Add -j1 to docs build invocation Add -j1 to docs build invocation Oct 23, 2024
@tcharding
Copy link
Member Author

Ouch this makes run_task docsrs painfully slow - only matters locally, in CI that shouldn't matter too much. No one twiddles their thumbs while CI is spinning, right?

@tcharding
Copy link
Member Author

Tested on rust-bitcoin/rust-bitcoin#3507

@apoelstra
Copy link
Member

Ouch this makes run_task docsrs painfully slow -

If it's buggy when run in parallel unfortunately I think we have to live with this.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9766b0d

@tcharding
Copy link
Member Author

tcharding commented Oct 24, 2024

Agreed, I never run run_task docs anyway, I use just docsrs.

@apoelstra apoelstra merged commit 4f17a05 into rust-bitcoin:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants