Add a verify function to PublicKey
#642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
changed the title
verify function to PublicKey
|
This does not compile. |
lolz, this reminds me of the most painfully educational review I ever got on LKML "Does this even compile?" |
tcharding
force-pushed
the
08-09-ecdsa-pubkey-verify
branch
from
59e473c
to
e816173
Compare
|
Rebase only, no other changes. If I get green CI first go I win :) |
|
Ouch! You win. |
tcharding
force-pushed
the
08-09-ecdsa-pubkey-verify
branch
from
e816173
to
6f9dab1
Compare
|
Feature gated imports were incorrect |
To be uniform with `XOnlyPublicKey` add a `verify` function to the `PublicKey`.
tcharding
force-pushed
the
08-09-ecdsa-pubkey-verify
branch
from
6f9dab1
to
b9cb37d
Compare
|
And the formatter, it is hard to get good help. |
apoelstra
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be uniform with
XOnlyPublicKeyadd averifyfunction to thePublicKey.Should have been done when we did #618