Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sign_schnorr_no_aux_rand for Keypair #762

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

witter-deland
Copy link
Contributor

@witter-deland witter-deland commented Nov 3, 2024

@apoelstra
Copy link
Member

In be017c2:

There is trailing whitespace on multiple lines.

But concept ACK.

@witter-deland
Copy link
Contributor Author

fixed :)

In be017c2:

There is trailing whitespace on multiple lines.

But concept ACK.

@apoelstra
Copy link
Member

In 9f75b63:

There is still a trailing space on line 1017 :)

@witter-deland
Copy link
Contributor Author

fixed :)

In 9f75b63:

There is still a trailing space on line 1017 :)

@apoelstra
Copy link
Member

Please squash these commits.

@witter-deland
Copy link
Contributor Author

Done, thank you for your patience

Please squash these commits.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2d29116; successfully ran local tests; thanks for iterating!

@apoelstra apoelstra merged commit 2bfda46 into rust-bitcoin:master Nov 3, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants