feat(stream): Initial support for auto-adapting streams #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of #5.
This is only supporting
AlwaysAnsi
andNever
and only using TTY and wincon information.Future work
Areas of uncertainty
always_ansi
callwindows::enable_ansi_colors
? Probably but then we'd need to make sure it doesn't get called twice in a rowIn doing this, I made
println
bypass one of the common pitfalls for CLI authors: the panic on broken pipe. This will instead let the application keep printing which is a better default.Another CLI pitfall is the performance of using the non-locked version. This also means not having a
println
. I decided to go ahead and favor ergonomics and instead be very explicit in the documentation about this