JS also supports fallible ctors #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
commented
Jan 15, 2025
| @@ -40,7 +40,7 @@ pub mod ffi { | |||
| Err(()) | |||
| } | |||
|
|
|||
| #[diplomat::attr(all(*, supports = fallible_constructors), named_constructor = "failing_struct")] | |||
| #[diplomat::attr(all(supports = named_constructors, supports = fallible_constructors), named_constructor = "failing_struct")] | |||
There was a problem hiding this comment.
thought: we should support auto inside toplevel all even if we don't support it inside any
ambiguousname
approved these changes
Jan 15, 2025
Manishearth
force-pushed
the
js-fallible
branch
from
f024d39 to
9b5ab3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.