Enhanced shell example #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejpster
force-pushed
the
enhanced-shell
branch
from
343b9fc to
9f7ba37
Compare
jannic
reviewed
Dec 20, 2023
|
@jannic is this good to go after those changes? |
Sometimes you get this error if a *directory* was not found, so it was confusing.
* Converting "" to a ShortFileName, gives you ShortFileName::this_dir() or ".<10 spaces>", which is the special entry at the top of every directory. * You can open the same directory multiple times. This is required if you want to walk a path, but also hold open a directory in that path. * Lets you open "." and get a duplicate handle to a directory * Lets you mutate a Directory object to point at a child, without having to make a new Directory object and drop the old one.
Each command is now a function.
Handle relative paths in "mkdir", "dir", "cat" and "hexdump". Not currently supported in "cd".
Also volumes are letters.
jonathanpallant
force-pushed
the
enhanced-shell
branch
from
3bdb40a to
8f0e37c
Compare
jannic
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell example now supports some relative paths and some new commands.