Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better volume label support #144

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Better volume label support #144

merged 4 commits into from
Oct 11, 2024

Conversation

thejpster
Copy link
Member

@thejpster thejpster commented Oct 6, 2024 •
edited
Loading

Now you can ask for the label of a volume. The shell example also now prints the volume label on start-up.

$ cargo run --example shell --release -- ./disk.img
    Finished `release` profile [optimized] target(s) in 0.03s
     Running `target/release/examples/shell ./disk.img`
Opening './disk.img'...
Volume # A: found, label: Some(VolumeName("TEST FAT16"))
Volume # B: found, label: Some(VolumeName("TEST FAT32"))
Failed to open volume 2: FormatError("Partition type not supported")
Failed to open volume 3: FormatError("Partition type not supported")
A:/>

@thejpster
Copy link
Member Author

Closes #145

jannic
jannic previously approved these changes Oct 11, 2024
View reviewed changes
src/fat/bpb.rs Show resolved Hide resolved
@thejpster
Minor tidy up
db06494 
match on enums, don't use if
@thejpster
Better support for volume labels.
a340b4d 
They can contain spaces! But not full-stops.
@thejpster
Simplify some casts
77b45be 
Avoid try_from ... unwrap. We can just use 'as', which is easier to understand.
@thejpster
Add extra test opening volumes.
3548e14
@thejpster
Copy link
Member Author

Rebased

@thejpster thejpster added this pull request to the merge queue Oct 11, 2024
Merged via the queue into develop with commit 504b440 Oct 11, 2024
8 checks passed
@thejpster thejpster mentioned this pull request Oct 12, 2024
Closed
@thejpster thejpster deleted the more-volume-labels branch October 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannic jannic jannic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thejpster @jannic