Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove byteorder dependency #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove byteorder dependency #16

wants to merge 1 commit into from

Conversation

newpavlov
Copy link

No description provided.

@rursprung
Copy link

i ran cargo-msrv both on main and this PR:

  • without this PR and with the default dependency resolution (automatically selecting the latest semver-compatible dependency version, at this time 1.5.0) the MSRV is 1.60
  • without this PR and with forcing the dependency to =1.2.2 the MSRV is 1.55
  • with this PR the MSRV is 1.55

i took the liberty of raising the MSRV to 1.56 in #18 because i don't think that this step from 1.55 to 1.56 is a huge deal (and most probably anyway are already on newer versions).

@newpavlov
Copy link
Author

It's possible to restore byterorder's MSRV, but I don't when the PR will be merged. Either way, I don't think this crate needs to pull byteorder in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newpavlov @rursprung