Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appendix: add hint about ST-LINK config version #272

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

julianoes
Copy link
Contributor

My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output.

I suggest to hint to try the older version in that case.

I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise.

Related to rust-embedded/book#263.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @andre-richter (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Oct 17, 2020
My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config
interface which caused the same "Error: open failed" output.

I suggest to hint to try the older version in that case.

I've also separated Cause and Fix headings because I didn't know how to
phrase it otherwise.
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

bors r+

bors bot added a commit that referenced this pull request Oct 17, 2020
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes

My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output.

I suggest to hint to try the older version in that case.

I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise.

Related to rust-embedded/book#263.

Co-authored-by: Julian Oes <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2020

Build failed:

@eldruin
Copy link
Member

eldruin commented Oct 17, 2020

bors retry

bors bot added a commit that referenced this pull request Oct 17, 2020
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes

My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output.

I suggest to hint to try the older version in that case.

I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise.

Related to rust-embedded/book#263.

Co-authored-by: Julian Oes <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2020

Build failed:

@eldruin
Copy link
Member

eldruin commented Oct 17, 2020

bors retry

bors bot added a commit that referenced this pull request Oct 17, 2020
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes

My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output.

I suggest to hint to try the older version in that case.

I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise.

Related to rust-embedded/book#263.

Co-authored-by: Julian Oes <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2020

Build failed:

@eldruin
Copy link
Member

eldruin commented Oct 18, 2020

bors retry

bors bot added a commit that referenced this pull request Oct 18, 2020
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes

My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output.

I suggest to hint to try the older version in that case.

I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise.

Related to rust-embedded/book#263.

Co-authored-by: Julian Oes <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 18, 2020

Build failed:

@eldruin
Copy link
Member

eldruin commented Oct 18, 2020

bors retry

bors bot added a commit that referenced this pull request Oct 18, 2020
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes

My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output.

I suggest to hint to try the older version in that case.

I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise.

Related to rust-embedded/book#263.

Co-authored-by: Julian Oes <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 18, 2020

Build failed:

@eldruin
Copy link
Member

eldruin commented Oct 18, 2020

Does somebody know what is wrong with bors/travis here? @rust-embedded/resources

@therealprof
Copy link
Contributor

If in doubt I'd say it's a Travis CI cache problem. For some reason I can't find the clear cache item anymore...

@julianoes
Copy link
Contributor Author

Bump :)

@eldruin
Copy link
Member

eldruin commented Oct 26, 2020

I have cleared the cache in Travis now.

bors retry

@bors
Copy link
Contributor

bors bot commented Oct 26, 2020

Build succeeded:

@bors bors bot merged commit 36c2563 into rust-embedded:master Oct 26, 2020
@therealprof
Copy link
Contributor

@eldruin How did you manage to do that? Via CLI?

@julianoes julianoes deleted the pr-stlink-interface branch October 26, 2020 07:43
@julianoes
Copy link
Contributor Author

Thanks 🙏

@eldruin
Copy link
Member

eldruin commented Oct 26, 2020

@therealprof I could see the clear cache option. At least for me it is there in the burger menu -> caches -> recycle bin icon.

@therealprof
Copy link
Contributor

Meanwhile I saw that in the other PR 😅. No idea why it is gone for me but I'm glad you managed to sort it out.

I was contemplating to move to GHA but then I saw the script salad which is our CI and backed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants