-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appendix: add hint about ST-LINK config version #272
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @andre-richter (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output. I suggest to hint to try the older version in that case. I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise.
7ea8b69
to
bd98caf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
bors r+
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output. I suggest to hint to try the older version in that case. I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise. Related to rust-embedded/book#263. Co-authored-by: Julian Oes <[email protected]>
Build failed: |
bors retry |
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output. I suggest to hint to try the older version in that case. I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise. Related to rust-embedded/book#263. Co-authored-by: Julian Oes <[email protected]>
Build failed: |
bors retry |
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output. I suggest to hint to try the older version in that case. I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise. Related to rust-embedded/book#263. Co-authored-by: Julian Oes <[email protected]>
Build failed: |
bors retry |
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output. I suggest to hint to try the older version in that case. I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise. Related to rust-embedded/book#263. Co-authored-by: Julian Oes <[email protected]>
Build failed: |
bors retry |
272: appendix: add hint about ST-LINK config version r=eldruin a=julianoes My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output. I suggest to hint to try the older version in that case. I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise. Related to rust-embedded/book#263. Co-authored-by: Julian Oes <[email protected]>
Build failed: |
Does somebody know what is wrong with bors/travis here? @rust-embedded/resources |
If in doubt I'd say it's a Travis CI cache problem. For some reason I can't find the clear cache item anymore... |
Bump :) |
I have cleared the cache in Travis now. bors retry |
Build succeeded: |
@eldruin How did you manage to do that? Via CLI? |
Thanks 🙏 |
@therealprof I could see the clear cache option. At least for me it is there in the burger menu -> caches -> recycle bin icon. |
Meanwhile I saw that in the other PR 😅. No idea why it is gone for me but I'm glad you managed to sort it out. I was contemplating to move to GHA but then I saw the script salad which is our CI and backed out. |
My F3 seemed to come with the stlink-v2 and not the stlink-v2-1 config interface which caused the same "Error: open failed" output.
I suggest to hint to try the older version in that case.
I've also separated Cause and Fix headings because I didn't know how to phrase it otherwise.
Related to rust-embedded/book#263.