Add CString
#342
Draft
Add CString
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| /// Stores up to N-1 elements with a byte reserved for the terminating nil byte. | ||
| #[derive(Clone)] | ||
| pub struct CString<const CAP: usize> { |
There was a problem hiding this comment.
Suggested change
| pub struct CString<const CAP: usize> { | |
| pub struct CString<const N: usize> { |
to be consistent with the other types.
| /// ); | ||
| /// ``` | ||
| #[inline] | ||
| pub fn as_bytes_with_null(&self) -> &[u8] { |
There was a problem hiding this comment.
Suggested change
| pub fn as_bytes_with_null(&self) -> &[u8] { | |
| pub fn as_bytes_with_nul(&self) -> &[u8] { |
to be consistent with std.
| /// Ok("heapless") | ||
| /// ); | ||
| /// ``` | ||
| pub fn to_str(&self) -> Result<&str, core::str::Utf8Error> { |
There was a problem hiding this comment.
Implement Deref<Target = CStr> instead to get this automatically.
| } | ||
|
|
||
| /// | ||
| pub fn as_ptr(&self) -> *const u8 { |
There was a problem hiding this comment.
Implement Deref<Target = CStr> instead to get this automatically.
| } | ||
|
|
||
| /// TODO | ||
| pub fn as_mut_ptr(&mut self) -> *mut u8 { |
There was a problem hiding this comment.
std::ffi::CString only has into_raw.
|
@vrmiguel, do you still plan on working on this? |
|
@reitermarkus If @vrmiguel is busy, maybe can someone take over this work? I'm also interested in this feature and wouldn't mind to help making changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still in draft but feel free to review or comment on it
Closes #330