Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: define pmpcfgx types with CSR macros #257

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

rmsyn
Copy link
Contributor

@rmsyn rmsyn commented Jan 19, 2025

Uses CSR helper macros to define pmpcfgx field types.

Related: #229

@rmsyn rmsyn requested a review from a team as a code owner January 19, 2025 18:54
romancardenas
romancardenas previously approved these changes Jan 24, 2025
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I say in the ISA that now there are pmpcfg registers from 1 to 15. Should we add them in a future PR?

@rmsyn
Copy link
Contributor Author

rmsyn commented Jan 25, 2025

Should we add them in a future PR?

I think this is a good idea. That way the discussions can focus entirely on their addition. Also, I think it will tie in with the ongoing work to make all CSR writes unsafe.

@romancardenas
Copy link
Contributor

@rmsyn please fix conflicts

Uses CSR helper macros to define `pmpcfgx` field types.
@romancardenas romancardenas added this pull request to the merge queue Jan 27, 2025
Merged via the queue into rust-embedded:master with commit f92d787 Jan 27, 2025
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants