Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv-rt patch: remove references to eh_frame #264

Closed
wants to merge 1 commit into from

Conversation

romancardenas
Copy link
Contributor

This PR serves to give me permission to publish a v0.13.1 patch fr riscv-rt. This release cherry-picks a commit that is already in master, but remains still unpublished.

Note that, if accepted, I will publish the patch from the rvrt-patch branch, not master.

Closes #260

@romancardenas romancardenas requested a review from a team as a code owner February 8, 2025 10:45
@romancardenas romancardenas changed the title riscv-rt patch: remove references to eh_frame` riscv-rt patch: remove references to eh_frame Feb 8, 2025
Copy link
Contributor

@rmsyn rmsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that, if accepted, I will publish the patch from the rvrt-patch branch, not master.

Why do you prefer publishing from rvrt-patch instead of master?

Otherwise, this LGTM.

@romancardenas
Copy link
Contributor Author

We can either wait and do a "major" release including riscv or release this patch ASAP and do the major release later. Whatever you prefer

@rmsyn
Copy link
Contributor

rmsyn commented Feb 11, 2025

We can either wait and do a "major" release including riscv or release this patch ASAP and do the major release later. Whatever you prefer

Maybe we can bring it up at tomorrow's meeting?

I think if we're doing a release with riscv also, maybe it could wait until we're ready for the next release we're working on? Especially since users who need it now can track the master branch.

Doing a patch release only for riscv-rt makes more sense to me, if we want to publish a release to crates.io now.

Would definitely like to get more feedback from others in the working group.

@romancardenas
Copy link
Contributor Author

I guess it also depends on how long will it take to have the next version of riscv ready. I think the only blocker is #229 right?

@rmsyn
Copy link
Contributor

rmsyn commented Feb 11, 2025

I think the only blocker is #229 right?

If that is the only blocker, I can try to finish the final few registers by the end of the week.

@romancardenas
Copy link
Contributor Author

OK, let's do that. We will wait a bit and release a new version of all the riscv packages once we are done with #229.

@romancardenas romancardenas deleted the release-rvrt-patch branch February 26, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

riscv rt linker issue with cargo build
2 participants