Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Chapter 5 and modify the source file format #187

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

Jzow
Copy link
Contributor

@Jzow Jzow commented Sep 9, 2023

Description

Related Issue: CC #166

Pre-commit steps

  • Tested on QEMU and real HW Rasperry Pi.
    • Not needed if it is just a README change or similar.
  • Ran ./contributor_setup.sh followed by ./devtool ready_for_publish
    • You'll need Ruby with Bundler and NPM installed locally.
    • If no Rust-related files were changed, ./devtool ready_for_publish_no_rust can be used instead (faster).
    • This step is optional, but much appreciated if done.

@Jzow
Copy link
Contributor Author

Jzow commented Sep 13, 2023

CC @colachg @readlnh Please review, thanks.

@Jzow
Copy link
Contributor Author

Jzow commented Sep 19, 2023

@Phantato Please review, thanks.

@Jzow
Copy link
Contributor Author

Jzow commented Sep 22, 2023

@eldruin Hi friend, I noticed that three friends who maintain Chinese translations have not been active on Github for a long time, and the PR for this translation may not receive feedback. Therefore, I suggest finding a partner to proofread translation files. I want to complete this work earlier.

@eldruin
Copy link
Member

eldruin commented Sep 25, 2023

Hi @Jzow, I have asked in our chat room but nobody responded.
Do you feel confident enough with your translation so that we could merge it as-is (after rebasing to master so that CI works)?
Users can always submit improvements/fixes later on.

@Jzow
Copy link
Contributor Author

Jzow commented Sep 25, 2023

I have asked in our chat room but nobody responded.

Thanks for your prompt reply.

Do you feel confident enough with your translation so that we could merge it as-is (after rebasing to master so that CI works)?

Firstly, I am happy to do translation work, making it easier for some friends to read. At the same time, I can also understand embedded knowledge from it so that I can try to contribute code from rust-embedded repositories in the future. I believe I should be competent for this translation job. If there are any translation issues, I will proofread and update them at any time.

If there are new colleagues to submit improvements/fixes in the future, that would be great.

@eldruin
Copy link
Member

eldruin commented Sep 25, 2023

Ok, thanks. Once you rebase this to master so that CI works, I will merge it.

@Jzow
Copy link
Contributor Author

Jzow commented Sep 25, 2023

Don't need to change to the master branch, just reopen it and have it perform CI validation once.

Each chapter translation should correspond to a branch, and after merging, I will delete the corresponding branch of my fork.

@Jzow Jzow closed this Sep 25, 2023
@Jzow Jzow reopened this Sep 25, 2023
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eldruin eldruin merged commit daee880 into rust-embedded:master Sep 25, 2023
@Jzow Jzow deleted the translate-cn-05 branch September 25, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants