-
-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Chapter 5 and modify the source file format #187
Conversation
@Phantato Please review, thanks. |
@eldruin Hi friend, I noticed that three friends who maintain Chinese translations have not been active on Github for a long time, and the PR for this translation may not receive feedback. Therefore, I suggest finding a partner to proofread translation files. I want to complete this work earlier. |
Thanks for your prompt reply.
Firstly, I am happy to do translation work, making it easier for some friends to read. At the same time, I can also understand embedded knowledge from it so that I can try to contribute code from If there are new colleagues to submit improvements/fixes in the future, that would be great. |
Ok, thanks. Once you rebase this to master so that CI works, I will merge it. |
Don't need to change to the master branch, just reopen it and have it perform CI validation once. Each chapter translation should correspond to a branch, and after merging, I will delete the corresponding branch of my fork. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Related Issue: CC #166
Pre-commit steps
./contributor_setup.sh
followed by./devtool ready_for_publish
Ruby
withBundler
andNPM
installed locally../devtool ready_for_publish_no_rust
can be used instead (faster).