-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable respace #879
base: master
Are you sure you want to change the base?
disable respace #879
Conversation
/ci diff pr |
/ci diff pr |
997e12c
to
6b84925
Compare
/ci diff pr |
@Emilgardis Let's merge this too. This should be done in |
cc @thejpster |
why was this made into a draft again? |
I took some time to rewrite |
/ci diff pr |
/ci diff -c rp2350 pr |
Diff for comment |
/ci diff pr |
I dont enjoy the output :/ doesn't look good |
What do you suggest? |
Hmm, I guess the problem I have is how the source material is formatted. is there a issue/pr for improving the descriptions in the patched svds? |
For adequate support But I still not sure about syntax:
4.) always process this special case: replace |
Could we reverse the information about where the text in the description starts, then apply that spacing and then do a "unindent"? |
Could you show example? I don't understand what you mean. |
take for example this: # line 1542 in stm32f303.svd.patched
<interrupt>
<name>PVD</name>
<description>PVD through EXTI line detection
interrupt</description>
<value>1</value>
</interrupt> this gets translated to #[doc = "1 - PVD through EXTI line detection\n interrupt"] instead, I think since we can, via #[doc = "1 - PVD through EXTI line detection\ninterrupt"] however, looking at the doc for |
You mean to check that text indentation is equal to tag indentation? |
Yes, essentially. I'm fine with merging this however, but I'm a bit suspicious about if we're really handling this in a good way or not. |
Closes #858