Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more llvm instrumentations #402

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

0xdeafbeef
Copy link
Contributor

Fix not working disable_branch_folding

@0xdeafbeef 0xdeafbeef force-pushed the 0xdeafbeef/push-tqronnqkpknw branch 2 times, most recently from bdb8c7f to 46a7dcd Compare February 24, 2025 13:02
@@ -165,7 +179,7 @@ pub struct BuildOptions {
/// Note, that in the second program, there are now 2 new coverage feedback points,
/// and the fuzzer can store an input to the corpus at each condition that it passes;
/// giving it a better chance of producing an input that reaches `res = 2;`.
pub disable_branch_folding: Option<bool>,
pub disable_branch_folding: bool,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an Option because the default value was "true", now the default is "false". Add this to set the default to "true":

    #[arg(long, default_value_t = true)]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@0xdeafbeef 0xdeafbeef force-pushed the 0xdeafbeef/push-tqronnqkpknw branch from 46a7dcd to 2e41070 Compare March 7, 2025 11:25
@0xdeafbeef 0xdeafbeef requested a review from tmpolaczyk March 7, 2025 21:12
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen merged commit 65e3279 into rust-fuzz:main Mar 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants