Skip to content

Release Team link is broken #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexhrao opened this issue Feb 8, 2024 · 6 comments · Fixed by rust-lang/www.rust-lang.org#1929
Closed

Release Team link is broken #1246

alexhrao opened this issue Feb 8, 2024 · 6 comments · Fixed by rust-lang/www.rust-lang.org#1929

Comments

@alexhrao
Copy link

alexhrao commented Feb 8, 2024

The release team link (as seen on this page) no longer works. The link is https://www.rust-lang.org/governance/teams/release

I can't seem to find where it should point to, but in any case right now it's a broken link.

@ehuss
Copy link
Contributor

ehuss commented Feb 8, 2024

Thanks for the report! There is an issue with the website where the redirects have stopped working. This is tracked in rust-lang/www.rust-lang.org#1921.

@CleanCut
Copy link
Contributor

CleanCut commented Feb 8, 2024

Perhaps the release team is part of (or was folded into?) the Infra Team?

Releases is listed as their responsibility:

Image

@CleanCut
Copy link
Contributor

CleanCut commented Feb 8, 2024

@ehuss There isn't a redirect listed for governance/teams/release in that file on the commit you linked or on master.

@senekor
Copy link
Contributor

senekor commented Feb 8, 2024

The route /governance/<section>/<team> is rendered dynamically based on data from https://team-api.infra.rust-lang.org/v1/teams.json. There actually is a release team in that data (a subteam of infra), so I think this is an issue on the side of www.rust-lang.org. (But it is a separate issue from the general redirect problem.) I'll investigate further.

@senekor
Copy link
Contributor

senekor commented Feb 8, 2024

Looks like pages for subteams are deliberately not shown. Since release is a subteam of infra, that applies there as well. I don't know what the reason or the best way to fix it is. The code snippet is from here.

// Don't show pages for subteams
if let Some(subteam) = &main_team.subteam_of {
    // Launching-pad does not have a page of its own, but we do want
    // to show the working groups that are inside it.
    if subteam != "launching-pad" {
        return Err(TeamNotFound.into());
    }
}

@senekor
Copy link
Contributor

senekor commented Feb 8, 2024

Ok it makes sense to me now, the subteams are listed as sections on the page of the parent team. So the correct link would probably be https://www.rust-lang.org/governance/teams/infra#Release%20team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants