Skip to content

Broken link #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apiraino opened this issue Feb 8, 2024 · 5 comments · Fixed by #1924
Closed

Broken link #1921

apiraino opened this issue Feb 8, 2024 · 5 comments · Fixed by #1924
Labels
A-Content The written content on the website. C-Bug Something isn't working.

Comments

@apiraino
Copy link
Contributor

apiraino commented Feb 8, 2024

What needs to be fixed?

I reached the page https://www.rust-lang.org/team.html and got a 422 error. Debug from Rocket running on localhost:

GET /team.html text/html:
   >> Matched: (category_en) GET /<category>
   >> Parameter guard `category: Category` is forwarding: "No category called <team.html>".
   >> Outcome: Forward(422 Unprocessable Entity)
   >> Matched: (index_locale) GET /<locale> [3]
   >> Parameter guard `locale: SupportedLocale` is forwarding: ().
   >> Outcome: Forward(422 Unprocessable Entity)
   >> No matching routes for GET /team.html text/html.
   >> No 422 catcher registered. Using Rocket default.
   >> Response succeeded.

I reached that page by opening this sub-team link.

Page(s) Affected

https://www.rust-lang.org/team.html

Suggested Improvement

Is the page supposed to be there? Was it moved?

Will have a look at that, opening an issue as a reminder

@apiraino apiraino added A-Content The written content on the website. C-Bug Something isn't working. labels Feb 8, 2024
@Manishearth
Copy link
Member

It's an old link. It should link to /governance instead.

@ehuss
Copy link
Contributor

ehuss commented Feb 8, 2024

I believe there is a larger problem where all of the redirects have stopped working for the past few days (perhaps since the last deploy?). This has resulted in broken links in various places. @weihanglo speculated it was the update to Rocket 0.5.

cc rust-lang/cargo#13408 and rust-lang/blog.rust-lang.org#1246

@Manishearth
Copy link
Member

Hm yeah! when I saw this I was like "I swear there was a redirect there" but I figured it was /team and not /team.html.

@Manishearth
Copy link
Member

We should fix the redirect stuff, yeah

@senekor
Copy link
Contributor

senekor commented Feb 8, 2024

You're right, the rocket v0.5 update caused this. I have a fix inbound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Content The written content on the website. C-Bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants