Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Specify all of toml_edit's features #12765

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

epage
Copy link
Contributor

@epage epage commented Oct 2, 2023

This is preventing us from being able to update toml/toml_edit independent of each other since the new versions are both breaing changes, so by updating one, we are getting the features enabled for us by the wrong version.

This is preventing us from being able to update toml/toml_edit
independent of each other.
@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2023
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Works well. Thanks!

@Muscraft
Copy link
Member

Muscraft commented Oct 4, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Oct 4, 2023

📌 Commit d3c47f1 has been approved by Muscraft

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2023
@bors
Copy link
Contributor

bors commented Oct 4, 2023

⌛ Testing commit d3c47f1 with merge 8ea9c23...

@bors
Copy link
Contributor

bors commented Oct 4, 2023

☀️ Test successful - checks-actions
Approved by: Muscraft
Pushing 8ea9c23 to master...

@bors bors merged commit 8ea9c23 into rust-lang:master Oct 4, 2023
@epage epage deleted the toml branch October 4, 2023 16:32
@ehuss ehuss added this to the 1.75.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants