-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate build-rs to the Cargo repo #14786
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5448ed7
Initial implementation
CAD97 41ea720
Add simple example
CAD97 22c1e9e
Add autopublish CI job
CAD97 4a6d465
Add extra missing metadata
CAD97 6655e48
Bump version
CAD97 401f77a
Big refactor
epage e5516ae
configure renovate
CAD97 7a50053
configure renovate
CAD97 66a2544
configure renovate
CAD97 657b2aa
configure renovate
CAD97 85896ca
update renovate
CAD97 9b627d6
Update dependency rust-version to v1.75
renovate[bot] 25f8bd7
Update dependency rust-version to v1.76
renovate[bot] e243d71
Update renovate config
CAD97 4f60fe0
Cleanup before upstream submission
CAD97 b62c598
chore: Remove build-rs CI
epage 0c7577d
chore: Stage build-rs for merging
epage 8b9eaa5
chore: Merge build-rs into Cargo
epage 54660c6
chore: Integrate build-rs into the workspace
epage 82a912a
chore: Silence clippy for intregration
epage 80c117a
chore(ci): Don't check build-rs against past commits
epage 9814045
docs: Declare build-rs as intentional
epage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
docs: Declare build-rs as intentional
- Loading branch information
commit 9814045a034dd361bf590fbcaba7b54b44c8ff14
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
> This crate is maintained by the Cargo team for use by the wider | ||
> ecosystem. This crate follows semver compatibility for its APIs. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to explicitly exempt the
unstable
feature here, and/or migrate it to using a cfg (likeprocmacro2_semver_exempt
) instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My assumption is that its fine as that feature is documented as unstable. I'm not even sure why that line is encouraged in the policy. Pretty much every lib is assumed to follow semver.