suggest workspace hints for boolean dependencies #15507
Open
+53
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
via issue #15505, Cargo currently errors on
with a message about
expected a version string or a detailed dependency
It doesn’t hint that you can depend on a workspace member. This PR updatescargo
so that when you write dep = true, the error also suggests:How should we test and review this PR?
In a workspace crate’s Cargo.toml, add
Run
cargo build
and you should see the enhanced error with the two workspace hints.Additional information
Regarding support for int/float, we only need a special case for boolean because they’re the only values that get the
workspace hint
. Everything else just uses the normal detailed dependency error