Skip to content

Fix slow MacOS Travis issue. #6254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 2, 2018

OS X 10.13 images on Travis are running very slow and causing timeouts. This PR does two things:

  • Use OS X 10.12 (xode9.2) which is much faster.
  • Implement a change to the testsuite to handle 1-second resolution mtimes on HFS. When a test executes cargo multiple times, and the first run finishes in under 1 second, the second one will think it needs to rebuild because the mtime of the files equals the mtime of the output. This change forces the mtime of every project to be created 1 second in the past. Tests that are still sensitive to mtimes are adjusted on a case-by-case basis.

Closes #6239, Closes #5940

@ehuss ehuss requested a review from alexcrichton November 2, 2018 23:06
@alexcrichton
Copy link
Member

@bors: r+

Thanks so much for looking into this!

@bors
Copy link
Contributor

bors commented Nov 3, 2018

📌 Commit 20b5ca3 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Nov 3, 2018

⌛ Testing commit 20b5ca3 with merge 90a3c7d...

bors added a commit that referenced this pull request Nov 3, 2018
Fix slow MacOS Travis issue.

OS X 10.13 images on Travis are running very slow and causing timeouts. This PR does two things:

- Use OS X 10.12 (`xode9.2`) which is much faster.
- Implement a change to the testsuite to handle 1-second resolution mtimes on HFS. When a test executes cargo multiple times, and the first run finishes in under 1 second, the second one will think it needs to rebuild because the mtime of the files equals the mtime of the output. This change forces the mtime of every project to be created 1 second in the past. Tests that are still sensitive to mtimes are adjusted on a case-by-case basis.

Closes #6239, Closes #5940
@bors
Copy link
Contributor

bors commented Nov 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 90a3c7d to master...

@bors bors merged commit 20b5ca3 into rust-lang:master Nov 3, 2018
tesuji added a commit to tesuji/rust-clippy that referenced this pull request Oct 18, 2019
According to <rust-lang/cargo#6254 (comment)>,
macOS 10.12 (xode9.2) run much faster.
@ehuss ehuss added this to the 1.32.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis OSX build time very slow Timing errors on some cargo tests on macOS
3 participants