Fix compilation of C++ code for armv7-unknown-linux-gnueabihf #1298
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inclusion of features.h for armv7-unknown-linux-gnueabihf will, in
stubs-32.h, try to include stubs for hard or soft fp:
#if !defined __ARM_PCS_VFP
# include <gnu/stubs-soft.h>
#endif
#if defined __ARM_PCS_VFP
# include <gnu/stubs-hard.h>
#endif
gcc 13.3.0 as built by Yocto does not set __ARM_PCS_VFP unless
-mfloat-abi=hard is set. The build will fail as stubs-soft.h may not be
present.
Therefore, enable -mfloat-abi=hard when possible. gcc accepts it when an
FPU is selected (-mfpu=vfpv3-d16 in this case).
madsmtm
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inclusion of features.h for armv7-unknown-linux-gnueabihf will, in stubs-32.h, try to include stubs for hard or soft fp:
gcc 13.3.0 as built by Yocto does not set __ARM_PCS_VFP unless -mfloat-abi=hard is set. The build will fail as stubs-soft.h may not be present.
Therefore, enable -mfloat-abi=hard when possible. gcc accepts it when an FPU is selected (-mfpu=vfpv3-d16 in this case).