Fix: Fetch target info from Cargo even if Build::target is manually set
#1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first commit, I've documented more closely what
Build::targetdoes, which should avoid confusion like in #1297.And then it occurs to me that some users might be doing
build.target(&std::env::var("TARGET").unwrap())(even thoughBuild::targethas been available sincecc v1.0.0), which would give different behaviour than if they didn't do that (since we no longer source from Cargo). So I've added a hacky fix for this case.We might want to take it even further, and warn if both
TARGETandBuild::targetare set?